linux-kernel - Re: [PATCH] RTC v3020 fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.0.999.0708231222540.2049@enigma.security.iitk.ac.in>
Date:	Thu, 23 Aug 2007 12:26:38 +0530 (IST)
From:	Satyam Sharma <satyam@...radead.org>
To:	Mike Rapoport <mike@...pulab.co.il>
cc:	LKML <linux-kernel@...r.kernel.org>, Raphael Assenat <raph@...com>,
	Alessandro Zummo <a.zummo@...ertech.it>
Subject: Re: [PATCH] RTC v3020 fixes

Hi,

On Thu, 23 Aug 2007, Mike Rapoport wrote:

No changelog for patch ?!

> -	for ( i = 0; i < 4; i++ )
> +	for ( i = 0; i < 4; i++ ) {
>  		writel((address << (16-i)), EMV3020_VA_RTC);
> +		udelay(1);
> +	}
> +
> 

^ Spurious extra newline here.

> -	BCD_TO_BIN(dt->tm_mon);
> +	BCD_TO_BIN(dt->tm_mon - 1);

> -	emv3020_set_reg(0x06, dt->tm_mon);
> +	emv3020_set_reg(0x06, dt->tm_mon + 1);

Why? (looks unrelated to the udelay() fixes as well)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/