linux-kernel - Réf. : Re: [PATCH] export i386 smp_call_function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <OFA7B0E6E4.F9F637CF-ONC1257341.0069BD11-C1257341.0069BD5D@frec.bull.fr>
Date:	Fri, 24 Aug 2007 21:14:57 +0200
From:	laurent.vivier@...l.net
To:	Arjan van de Ven <arjan@...radead.org>
Cc:	Avi Kivity <avi@...ranet.com>,
	Laurent Vivier <Laurent.Vivier@...l.net>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>
Subject: Réf. : Re: [PATCH] export i386 smp_call_function_mask() to modules


> On Fri, 24 Aug 2007 17:36:35 +0200
> Laurent Vivier <Laurent.Vivier@...l.net> wrote:
>
> > This patch export i386 smp_call_function_mask() with EXPORT_SYMBOL().
> >
> > This function is needed by KVM to call a function on a set of CPUs.
> >
> >  arch/i386/kernel/smp.c |    7 +++++++
> >  include/asm-i386/smp.h |    9 +++------
> >  2 files changed, 10 insertions(+), 6 deletions(-)
> >
> > Signed-off-by: Laurent Vivier <Laurent.Vivier@...l.net>
>
> hmm isn't it being an inline also making it available for KVM to use?
> If so... isn't your patch description entirely not matching what the
> code does?

It is available for KVM compilation, not for KVM use.

In fact smp_ops is not available for KVM use, so as
smp_call_function_mask() is smp_ops.smp_call_function_mask() we can say it
is not available...

My first reflex was to export smp_ops, but as it seems it is an internal
and hidden variable, it appears I should export smp_call_function_mask()
instead.

Laurent


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/