linux-kernel - Re: DM_MULTIPATH_RDAC: "scsi_normalize

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 24 Aug 2007 15:16:27 -0700
From:	Chandra Seetharaman <sekharan@...ibm.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Martin Michlmayr <tbm@...ius.com>,
	Mike Christie <michaelc@...wisc.edu>,
	linux-kernel@...r.kernel.org
Subject: Re: DM_MULTIPATH_RDAC: "scsi_normalize_sense" undefined

On Fri, 2007-08-24 at 15:00 -0700, Randy Dunlap wrote:
> On Fri, 24 Aug 2007 14:33:02 -0700 Chandra Seetharaman wrote:
> 
> > It does, but "rdac" _is_ for a SCSI device.
> 
> It does __what__ ?  depend on SCSI?

Yes, as you understood it correctly :)

> I don't see that in drivers/md/Kconfig.
> Sounds like Martin is correct, SCSI needs to be added, like below.

I do agree that the following patch would be needed.

Since the rdac hardware handler is for a scsi device, including it
without SCSI would not achieve anything (as his device won't be visible
in the first place). Hence my question.

For completeness, I agree that we need the fix pointed below.
> 
> 
> > What device are you using it with ?
> > 
> > On Fri, 2007-08-24 at 18:08 +0200, Martin Michlmayr wrote:
> > > I just got:
> > > 
> > >   Building modules, stage 2.
> > >   MODPOST 414 modules
> > > ERROR: "scsi_normalize_sense" [drivers/md/dm-rdac.ko] undefined!
> > > make[1]: *** [__modpost] Error 1
> > > 
> > > Presumably DM_MULTIPATH_RDAC needs to depend on SCSI (not enabled
> > > here) since it uses scsi_normalize_sense.
> 
> ---
> 
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> DM_MULTIPATH_RDAC uses SCSI API(s) and is for a SCSI device,
> so add SCSI to its depends on to prevent build errors.
> 
> Not tested.
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> ---
>  drivers/md/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-2.6.23-rc3-git6.orig/drivers/md/Kconfig
> +++ linux-2.6.23-rc3-git6/drivers/md/Kconfig
> @@ -263,7 +263,7 @@ config DM_MULTIPATH_EMC
> 
>  config DM_MULTIPATH_RDAC
>  	tristate "LSI/Engenio RDAC multipath support (EXPERIMENTAL)"
> -	depends on DM_MULTIPATH && BLK_DEV_DM && EXPERIMENTAL
> +	depends on DM_MULTIPATH && BLK_DEV_DM && SCSI && EXPERIMENTAL
>  	---help---
>  	  Multipath support for LSI/Engenio RDAC.
> 
-- 

----------------------------------------------------------------------
    Chandra Seetharaman               | Be careful what you choose....
              - sekharan@...ibm.com   |      .......you may get it.
----------------------------------------------------------------------


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/