linux-kernel - Re: [PATCH] IdealTEK URTC1000 support for usbtouchscreen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200708251848.14866.daniel.ritz-ml@swissonline.ch>
Date:	Sat, 25 Aug 2007 18:48:13 +0200
From:	Daniel Ritz <daniel.ritz-ml@...ssonline.ch>
To:	Ondrej Zary <linux@...nbow-software.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] IdealTEK URTC1000 support for usbtouchscreen

	[ please don't send patches as attachment.. ]

On Thursday 23 August 2007 23:55:28 Ondrej Zary wrote:
> Hello,
> this patch adds support for IdealTEK URTC1000 touchscreen controllers.
> 

looks good, just a few minor things...

> Documentation can be downloaded at 
> http://projects.tbmn.org/cgi-bin/trac.cgi/wiki/urtc-1000
> 
> I'm not sure that the code is correct, especially because the .rept_size is 
> set to 8 bytes. I've tried 5, 6, 7, 8, 12 and 16. Only 8 and 16 work. Other 
> values resulted in -EOVERFLOW in usbtouch_irq() and infinite retries.
> 

8 is fine.

> Signed-off-by: Ondrej Zary <linux@...nbow-software.org>
> 

+       if (pkt[0] == 1) {
+               /* response string - ignore it */
+               char *end = strchr(pkt, '\r');
+               end[0] = 0;
+               dbg("IdealTEK response: %s\n", &pkt[1]);
+               return 0;

just remove this block

+       } else if ((pkt[0] & 0x98) == 0x88) {
+               /* touch data in IdealTEK mode */
+               dev->x = (pkt[1] << 5) | (pkt[2] >> 2);
+               dev->y = (pkt[3] << 5) | (pkt[4] >> 2);
+               dev->touch = (pkt[0] & 0x40) ? 1 : 0;
+               return 1;
+       } else if ((pkt[0] & 0x98) == 0x98) {
+               /* touch data in MT emulation mode */
+               dev->x = (pkt[2] << 5) | (pkt[1] >> 2);
+               dev->y = (pkt[4] << 5) | (pkt[3] >> 2);
+               dev->touch = (pkt[0] & 0x40) ? 1 : 0;
+               return 1;
+       } else {
+               dbg("IdealTEK: invalid data\n");
+               return 0;
+       }

and this one as well...and do a 'return 0;' as last statement
outside the 'if'

+               .process_pkt    = usbtouch_process_multi,

so you're using the support for packets split across two
URBs? is it required? if so, you have to ensure that the function
is compiled in. ie. extend this statement in the driver with your
config option:

#if defined(CONFIG_TOUCHSCREEN_USB_EGALAX) || defined(CONFIG_TOUCHSCREEN_USB_ETURBO)
#define MULTI_PACKET
#endif

the rest looks fine.

rgds
-daniel
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/