linux-kernel - Re: [PATCH] include linux/pagemap.h in asm-generic/tlb.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070824203424.8b47ff73.akpm@linux-foundation.org>
Date:	Fri, 24 Aug 2007 20:34:24 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Jeff Dike <jdike@...toit.com>
Cc:	LKML <linux-kernel@...r.kernel.org>, Rob Landley <rob@...dley.net>
Subject: Re: [PATCH] include linux/pagemap.h in asm-generic/tlb.h

On Fri, 24 Aug 2007 22:15:33 -0400 Jeff Dike <jdike@...toit.com> wrote:

> > So I think a better fix would be better, but I'm not able to suggest what,
> > as there is little detail about the failure here and I can find no mention
> > of page_cache_release and release_pages in asm-generic/tlb.h.  Presumably
> > they're getting pulled in via some macro and then instantiated in some
> > inline function or something?
> 
> Yes, it's straightforward - 
> 
> tlb.h:
> 
> static inline void
> tlb_flush_mmu(struct mmu_gather *tlb, unsigned long start, unsigned long end)
> {
> 	...
> 		free_pages_and_swap_cache(tlb->pages, tlb->nr);
> 	...
> }
> 
> swap.h:
> #define free_pages_and_swap_cache(pages, nr) \
> 	release_pages((pages), (nr), 0);

Oh that damn thing again.  It's a regular source of include breakage.

I suppose we could just uninline tlb_flush_mmu().
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/