linux-kernel - Re: [PATCH] [arch/i386/boot]: for better readability in clearing BSS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 26 Aug 2007 16:57:31 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Denis Cheng <crquan@...il.com>
CC:	Linux-Kernel@...r.kernel.org, cr_quan@....com
Subject: Re: [PATCH] [arch/i386/boot]: for better readability in clearing
 BSS

Denis Cheng wrote:
> 
> but their label names in .bss section are different,
> when reading these files, they are apt to confuse,
> 
> this patch kept them in the same style of clearing.
> 

Bullsh*t.

> diff --git a/arch/i386/boot/compressed/head.S b/arch/i386/boot/compressed/head.S
> index f35ea22..e499db0 100644
> --- a/arch/i386/boot/compressed/head.S
> +++ b/arch/i386/boot/compressed/head.S
> @@ -113,7 +113,7 @@ relocated:
>   * Clear BSS
>   */
>  	xorl %eax,%eax
> -	leal _edata(%ebx),%edi
> +	leal _bss(%ebx),%edi
>  	leal _end(%ebx), %ecx
>  	subl %edi,%ecx
>  	cld

Here you change _edata.._end into _bss.._end.

> diff --git a/arch/i386/boot/header.S b/arch/i386/boot/header.S
> index 7f4a2c5..cd074c1 100644
> --- a/arch/i386/boot/header.S
> +++ b/arch/i386/boot/header.S
> @@ -254,7 +254,7 @@ setup2:
>  
>  # Zero the bss
>  	movw	$__bss_start, %di
> -	movw	$_end+3, %cx
> +	movw	$__bss_end, %cx
>  	xorl	%eax, %eax
>  	subw	%di, %cx
>  	shrw	$2, %cx

Here you change __bss_start.._end to __bss_start..__bss_end, and have to
change the linker script for it not to break.

There is no consistency improvement, and as such, it's just churn.

	-hpa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/