[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20070826093544.GA4865@spock.one.pl>
Date: Sun, 26 Aug 2007 11:35:44 +0200
From: Michal Januszewski <spock@...too.org>
To: Randy Dunlap <randy.dunlap@...cle.com>
Cc: linux-fbdev-devel@...ts.sourceforge.net,
linux-kernel@...r.kernel.org
Subject: Re: [Linux-fbdev-devel] [PATCH] uvesafb: select connector in
Kconfig
On Sat, Aug 25, 2007 at 08:23:41AM -0700, Randy Dunlap wrote:
> There are 2 problems with this.
>
> a. CONNECTOR depends on NET, but select won't enable NET, so if
> NET is not enabled otherwise, CONNECTOR still won't build.
> This is a longstanding select/kconfig issue.
>
> b. CONNECTOR depends on NET, so if select did follow the depends
> chain and enable NET, it would be enabling the networking subsystem,
> which is something that should not be done quietly.
>
> select should only be used for enabling small library-like code
> (if even then). Avoid it whenever possible.
OK, thanks for pointing this out. Let's keep the original dependency
on CONNECTOR then.
Best regards,
Michal
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists