lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-id: <46D1BF71.3020602@shaw.ca>
Date:	Sun, 26 Aug 2007 11:59:13 -0600
From:	Robert Hancock <hancockr@...w.ca>
To:	Matthew Wilcox <matthew@....cx>
Cc:	linux-pci@...ey.karlin.mff.cuni.cz, linux-kernel@...r.kernel.org,
	Jesse Barnes <jesse.barnes@...el.com>, Greg KH <greg@...ah.com>
Subject: Re: [PATCH] Fix boot-time hang on G31/G33 PC

Matthew Wilcox wrote:
> On Sun, Aug 26, 2007 at 06:55:42AM -0600, Matthew Wilcox wrote:
>> On Sat, Aug 25, 2007 at 10:24:57PM -0600, Robert Hancock wrote:
>>> We've already got a patch for this in Greg's PCI tree, hopefully it 
>>> should go in for 2.6.24.
>> I haven't seen it.  I guess it wasn't sent to the PCI mailing list.
>>
>> Your patch had two or three problems with it; assuming we're talking
>> about the same patch.
> 
> I found
> http://git.kernel.org/?p=linux/kernel/git/gregkh/patches.git;a=blob;f=pci/pci-disable-decode-of-io-memory-during-bar-sizing.patch;h=958ef4e837733206a80f058aee236847eec5fbd8;hb=HEAD
> 
> which has two problems:
> 
>  - With a 64-bit BAR, it checks to see if the upper 32 bits represent IO
>    or memory.  You can't do that to the upper 32 bits.
>  - It does a lot of additional writes to the cmd register; my patch does two
>    writes per device; yours does two per BAR
> 
> It's also a lot more complex than my patch, IMO.
> 
> Greg, please drop Robert's patch and put mine in instead.

Based on looking at your patch it seems OK. The first problem you 
mentioned with what Jesse and I had there is definitely a valid one.

You can add my:

Acked-by: Robert Hancock <hancockr@...w.ca>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ