linux-kernel - Re: [RFC] block_device_operations prototype changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070827225901.GB30122@agk.fab.redhat.com>
Date:	Mon, 27 Aug 2007 23:59:01 +0100
From:	Alasdair G Kergon <agk@...hat.com>
To:	Al Viro <viro@....linux.org.uk>
Cc:	linux-kernel@...r.kernel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	linux-fsdevel@...r.kernel.org, axboe@...nel.dk
Subject: Re: [RFC] block_device_operations prototype changes

On Mon, Aug 27, 2007 at 11:30:53AM +0100, Al Viro wrote:
> 3) ->ioctl().  What a mess...  

Yup.

See also:
  Subject: [PATCH] dm: support ioctls on mapped devices: fix with fake file
  http://uwsg.indiana.edu/hypermail/linux/kernel/0606.2/2979.html

and related threads.

> First of all, we have 3 methods with different
> calling conventions:
> 	->ioctl(inode, file, cmd, arg)
> 	->unlocked_ioctl(inode, file, cmd, arg)

When I last looked it was:
  long (*unlocked_ioctl) (struct file *, unsigned int, unsigned long);
with the lack of inode forcing dm to use ->ioctl (because file can be NULL when
only the block device is known) and immediately drop the pointless-for-us
lock!

Alasdair
-- 
agk@...hat.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/