linux-kernel - Re: [md-accel PATCH 16/19] dmaengine: driver for the iop32x, iop33x, and iop13xx raid engines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c70ff3ad0708270614t6f17b38nfbdf84ace69b8d78@mail.gmail.com>
Date:	Mon, 27 Aug 2007 16:14:13 +0300
From:	"saeed bishara" <saeed.bishara@...il.com>
To:	"Dan Williams" <dan.j.williams@...el.com>
Cc:	linux-kernel@...r.kernel.org, linux-raid@...r.kernel.org,
	neilb@...e.de, akpm@...ux-foundation.org, davem@...emloft.net,
	christopher.leech@...el.com, shannon.nelson@...el.com,
	herbert@...dor.apana.org.au, jeff@...zik.org
Subject: Re: [md-accel PATCH 16/19] dmaengine: driver for the iop32x, iop33x, and iop13xx raid engines

Hi Dan,
I think you have a bug in this function, the list_splice_init adds the
new slots in the head of the chain_node, but you get the
old_chain_tail (latest descriptor) from the tail of the chain!!

 > +static dma_cookie_t
 > +iop_adma_tx_submit(struct dma_async_tx_descriptor *tx)
 > +{
 > +
 > +       old_chain_tail = list_entry(iop_chan->chain.prev,
 > +               struct iop_adma_desc_slot, chain_node);
 > +       list_splice_init(&sw_desc->group_list, &old_chain_tail->chain_node);
 > +
 > +       /* fix up the hardware chain */
 > +       iop_desc_set_next_desc(old_chain_tail, grp_start->phys);
 > +
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/