linux-kernel - Re: [PATCH] Add source address to sunrpc svc errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7788.1188328346@turing-police.cc.vt.edu>
Date:	Tue, 28 Aug 2007 15:12:26 -0400
From:	Valdis.Kletnieks@...edu
To:	"J. Bruce Fields" <bfields@...ldses.org>
Cc:	"Dr. David Alan Gilbert" <linux@...blig.org>,
	Randy Dunlap <randy.dunlap@...cle.com>, neilb@...e.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Add source address to sunrpc svc errors

On Mon, 27 Aug 2007 17:43:33 EDT, "J. Bruce Fields" said:

> Looks like a reasonable idea to me, thanks!  Any objection to just
> calling it "svc_printk" instead of "svc_printkerr"?
> 
> I also wonder whether these shouldn't all be dprintk's instead of
> printk's.  One misbehaving client could create a lot of noise in the
> logs.

I shouldn't have to rebuild my kernel with debugging enabled just to see
who is throwing trash at my machine.  printk(KERN_INFO maybe and/or using
a printk_ratelimit.

Content of type "application/pgp-signature" skipped