[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070828195503.GA15903@lst.de>
Date: Tue, 28 Aug 2007 21:55:03 +0200
From: Christoph Hellwig <hch@....de>
To: J??rn Engel <joern@...fs.org>
Cc: clameter@....com, torvalds@...ux-foundation.org,
linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
Christoph Hellwig <hch@....de>, Mel Gorman <mel@...net.ie>,
William Lee Irwin III <wli@...omorphy.com>,
David Chinner <dgc@....com>,
Jens Axboe <jens.axboe@...cle.com>,
Badari Pulavarty <pbadari@...il.com>,
Maxim Levitsky <maximlevitsky@...il.com>,
Fengguang Wu <fengguang.wu@...il.com>,
swin wang <wangswin@...il.com>, totty.lu@...il.com,
"H. Peter Anvin" <hpa@...or.com>,
"Eric W. Biederman" <ebiederm@...ssion.com>
Subject: Re: [07/36] Use page_cache_xxx in mm/filemap_xip.c
On Tue, Aug 28, 2007 at 09:49:38PM +0200, J??rn Engel wrote:
> On Tue, 28 August 2007 12:05:58 -0700, clameter@....com wrote:
> >
> > - index = *ppos >> PAGE_CACHE_SHIFT;
> > - offset = *ppos & ~PAGE_CACHE_MASK;
> > + index = page_cache_index(mapping, *ppos);
> > + offset = page_cache_offset(mapping, *ppos);
>
> Part of me feels inclined to marge this patch now because it makes the
> code more readable, even if page_cache_index() is implemented as
> #define page_cache_index(mapping, pos) ((pos) >> PAGE_CACHE_SHIFT)
>
> I know there is little use in yet another global search'n'replace
> wankfest and Andrew might wash my mouth just for mentioning it. Still,
> hard to dislike this part of your patch.
Yes, I I suggested that before. Andrew seems to somehow hate this
patchset, but even if we don;'t get it in the lowercase macros are much
much better then the current PAGE_CACHE_* confusion.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists