[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <46D5ED5C.9030405@linux.vnet.ibm.com>
Date: Thu, 30 Aug 2007 03:34:12 +0530
From: Balbir Singh <balbir@...ux.vnet.ibm.com>
To: Dave Hansen <haveblue@...ibm.com>
CC: Andrew Morton <akpm@...ux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Linux MM Mailing List <linux-mm@...ck.org>,
David Rientjes <rientjes@...gle.com>,
Linux Containers <containers@...ts.osdl.org>,
Paul Menage <menage@...gle.com>
Subject: Re: [-mm PATCH] Memory controller improve user interface
Dave Hansen wrote:
> On Wed, 2007-08-29 at 16:40 +0530, Balbir Singh wrote:
>>
>> @@ -352,7 +353,7 @@ int mem_container_charge(struct page *pa
>> kfree(pc);
>> pc = race_pc;
>> atomic_inc(&pc->ref_cnt);
>> - res_counter_uncharge(&mem->res, 1);
>> + res_counter_uncharge(&mem->res, MEM_CONTAINER_CHARGE_KB);
>> css_put(&mem->css);
>> goto done;
>> }
>
> Do these changes really need to happen anywhere besides the
> user<->kernel boundary? Why can't internal tracking be in pages?
I've thought about this before. The problem is that a user could
set his limit to 10000 bytes, but would then see the usage and
limit round to the closest page boundary. This can be confusing
to a user.
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists