linux-kernel - Re: [PATCH] sysctl: Deprecate sys_sysctl in a user space visible fashion.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070828214956.5f3020ef.akpm@linux-foundation.org>
Date:	Tue, 28 Aug 2007 21:49:56 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	ebiederm@...ssion.com (Eric W. Biederman)
Cc:	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] sysctl: Deprecate sys_sysctl in a user space visible
 fashion.

On Tue, 28 Aug 2007 16:40:15 -0600 ebiederm@...ssion.com (Eric W. Biederman) wrote:

> +static int deprecated_sysctl_warning(struct __sysctl_args *args)
> +{
> +	static int msg_count;
> +	int name[CTL_MAXNAME];
> +	int i;
> +
> +	/* Read in the sysctl name for better debug message logging */
> +	for (i = 0; i < args->nlen; i++)
> +		if (get_user(name[i], args->name + i))
> +			return -EFAULT;
> +
> +	/* Ignore accesses to kernel.version */
> +	if ((args->nlen == 2) && (name[0] == CTL_KERN) && (name[1] == KERN_VERSION))
> +		return 0;

Do we want to do all the above if msg_count>=5?

> +	if (msg_count < 5) {
> +		msg_count++;
> +		printk(KERN_INFO
> +			"warning: process `%s' used the deprecated sysctl "
> +			"system call with ", current->comm);
> +		for (i = 0; i < args->nlen; i++)
> +			printk("%d.", name[i]);
> +		printk("\n");
> +	}
> +	return 0;
> +}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/