[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070829111052.503a73a5@hyperion.delvare>
Date: Wed, 29 Aug 2007 11:10:52 +0200
From: Jean Delvare <khali@...ux-fr.org>
To: "Darrick J. Wong" <djwong@...ibm.com>
Cc: Henrique de Moraes Holschuh <hmh@....eng.br>,
"Mark M. Hoffman" <mhoffman@...htlink.com>,
linux-kernel@...r.kernel.org, lm-sensors@...sensors.org
Subject: Re: [PATCH] hwmon: Add power meters to
Documentation/hwmon/sysfs-interface
Hi Darrick,
On Tue, 28 Aug 2007 09:44:40 -0700, Darrick J. Wong wrote:
> Update the hwmon sysfs interface documentation to include a specification
> for power meters.
>
> Signed-off-by: Darrick J. Wong <djwong@...ibm.com>
> ---
>
> Documentation/hwmon/sysfs-interface | 15 +++++++++++++++
> 1 files changed, 15 insertions(+), 0 deletions(-)
>
> diff --git a/Documentation/hwmon/sysfs-interface b/Documentation/hwmon/sysfs-interface
> index b3a9e1b..da546ce 100644
> --- a/Documentation/hwmon/sysfs-interface
> +++ b/Documentation/hwmon/sysfs-interface
> @@ -304,6 +304,21 @@ curr[1-*]_input Current input value
> Unit: milliampere
> RO
>
> +*********
> +* Power *
> +*********
> +
> +power[1-*]_input Current power use
> + Unit: milliWatt
> + RO
> +
> +power[1-*]_max_input Historical maximum power use
> + Unit: milliWatt
> + RO
> +
> +power[1-*]_min_input Historical minimum power use
> + Unit: milliWatt
> + RO
>
I'm not sure if we want these "historical" files. We don't have them for
the other input types, and I believe that it's not the driver's job to
compute and export these values. If anyone cares about the history of
sensed values, that's something for a user-space application to
implement. This will also be much more flexible in user-space, as it
becomes possible to decide the exact time range to consider, to
remember at which time the peak occurred, etc.
--
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists