linux-kernel - Re: [PATCH] avoid negative (and full-width) shifts in radix-tree.c, take 3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070830004641.GA26580@atjola.homenet>
Date:	Thu, 30 Aug 2007 02:46:41 +0200
From:	Björn Steinbrink <B.Steinbrink@....de>
To:	Christoph Lameter <clameter@....com>
Cc:	Peter Lund <firefly@...64.dk>,
	Christoph Hellwig <hch@...radead.org>, trivial@...nel.org,
	linux-kernel@...r.kernel.org, Momchil Velikov <velco@...ata.bg>,
	"Maciej W. Rozycki" <macro@...ux-mips.org>
Subject: Re: [PATCH] avoid negative (and full-width) shifts in
	radix-tree.c, take 3

On 2007.08.29 10:49:12 -0700, Christoph Lameter wrote:
> On Wed, 29 Aug 2007, Peter Lund wrote:
> 
> >  
> > -	if (tmp >= RADIX_TREE_INDEX_BITS)
> > -		index = ~0UL;
> > -	return index;
> > +	if (shift < 0)
> > +		return ~0UL;
> > +	if (shift >= 8 * sizeof(unsigned long))
> 
> 8* sizeof(unsigned long) is the constant BITS_PER_LONG.

Or in this context: RADIX_TREE_INDEX_BITS, which happens to be the old
check, which just needed to be extended to cover negative shifts.

Björn
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/