linux-kernel - Re: [PATCH] snd_hda

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hd4x5gj2p.wl%tiwai@suse.de>
Date:	Thu, 30 Aug 2007 17:04:14 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Thomas Richter <rusricht@....uni-stuttgart.de>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] snd_hda_intel for F/S T4210

At Wed, 29 Aug 2007 17:34:19 +0200,
Thomas Richter wrote:
> 
> Hi folks,
> 
> the patch below, to be applied to sound/pci/hda/patch_sigmatel.c fixes the audio
> output on the Fujiutsu/Siemens lifebook T4210 (and probably on others). It is
> suitable for the kernel 2.6.23-rc4 (and probably others).
> 
> Without the patch, audio fails and the hda driver fails to load with
> 
> No available DAC for pin 0x0
> 
> However, the indicated pin has no connections in first place and thus should be ignored.
> With the patch applied audio output works fine.

The problem is that nid = 0 is used.  So, your patch just hides
another bug.

Please check whether the bug still exists with git.kernel.org
perex/alsa.git mm branch.  If still there, build with
CONFIG_SND_DEBUG and show the autoconfig output.


thanks,

Takashi


> 
> Here's the patch:
> 
> /* snip */
> --- patch_sigmatel_old.c        2007-08-29 17:17:51.000000000 +0200
> +++ patch_sigmatel.c    2007-08-29 17:21:25.000000000 +0200
> @@ -1250,6 +1250,16 @@
>                 nid = cfg->line_out_pins[i];
>                 conn_len = snd_hda_get_connections(codec, nid, conn,
>                                                    HDA_MAX_CONNECTIONS);
> +               /* FIX THOR: For some hardware (notably the Fujiutsu/Siemens T4210
> +               ** lifebook), we have nids with no pins whatsoever. Ignore
> +               ** them.
> +               */
> +               if (conn_len == 0) {
> +                 snd_printk(KERN_ERR "%s: Found zero connections for pin 0x%0x "
> +                            "ignoring it.\n",__func__,nid);
> +                 continue;
> +               }
> +
>                 for (j = 0; j < conn_len; j++) {
>                         wcaps = snd_hda_param_read(codec, conn[j],
>                                                    AC_PAR_AUDIO_WIDGET_CAP);
> /* snip */
> 
> Greetings,
> 	Thomas
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/