linux-kernel - Re: [PATCH] Version2 Smack: Simplified Mandatory Access Control Kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0708302059270.24730@fbirervta.pbzchgretzou.qr>
Date:	Thu, 30 Aug 2007 21:00:50 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...putergmbh.de>
To:	Thomas Bleher <ThomasBleher@....de>
cc:	Casey Schaufler <casey@...aufler-ca.com>, torvalds@...l.org,
	akpm@...l.org, linux-security-module@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Version2 Smack: Simplified Mandatory Access Control
 Kernel


On Aug 27 2007 23:59, Thomas Bleher wrote:

>> +       for (cp = data - 1; cp != NULL; cp = strchr(cp + 1, '\n')) {
>> +               if (*++cp == '\0')
>> +                       break;
>> +               if (sscanf(cp, "%14s %30s\n", name, target) != 2) {
>> +                       printk("%s:%d bad scan\n",
>> +                               __func__, __LINE__);
>
>Leftover debugging printk? Otherwise, a level would be nice.

Or even pr_debug.

(pr_debug("%s...

>> +	static struct tree_descr smack_files[] = {

Hey, can we make this const, if it does not change at runtime?


	Jan
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/