linux-kernel - [PATCH 2.6.23-rc2-rt2] call IRQ-chip's end hook in thread_simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 30 Aug 2007 20:07:45 -0700
From:	Kevin Hilman <khilman@...sta.com>
To:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	RT-Users <linux-rt-users@...r.kernel.org>
Subject: [PATCH 2.6.23-rc2-rt2] call IRQ-chip's end hook in thread_simple_irq()

When using the 'simple' handler as a chained handler, the end hook
should be called so the chained handler can properly ack/unmask
etc. after the threaded handler has completed.

In particular, the chained GPIO IRQ hander on OMAP uses the 'simple'
handler since the GPIO IRQs can be dynamically configured either as
edge or level.  When using threaded IRQs, the only way to know when
the handler is done and do the proper ack/unmask is via the end hook.

Signed-off-by: Kevin Hilman <khilman@...sta.com>

--- linux-2.6.21.orig/kernel/irq/manage.c
+++ linux-2.6.21/kernel/irq/manage.c
@@ -637,6 +637,8 @@ static void thread_simple_irq(irq_desc_t
 			note_interrupt(irq, desc, action_ret);
 	}
 	desc->status &= ~IRQ_INPROGRESS;
+	if (desc->chip->end)
+		desc->chip->end(irq);
 }

 /*
--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/