linux-kernel - RE: recent nfs change causes autofs regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <006c01c7ec06$e24378a0$a6ca69e0$@com>
Date:	Fri, 31 Aug 2007 12:41:09 -0700
From:	"Hua Zhong" <hzhong@...il.com>
To:	"'Trond Myklebust'" <trond.myklebust@....uio.no>
Cc:	"'Linus Torvalds'" <torvalds@...ux-foundation.org>,
	"'Frank van Maarseveen'" <frankvm@...nkvm.com>,
	"'Linux Kernel Mailing List'" <linux-kernel@...r.kernel.org>,
	<akpm@...ux-foundation.org>
Subject: RE: recent nfs change causes autofs regression

> It's not about default (for which backward compatibility is most
> important and this patch is perfectly fine), but user explicitly asks
> for "sharecache". In this case if for any reason the cache cannot be
> shared, I am not sure if he should get an error back.
> 
> I for one agree with Ian and Linus that changing default to
> nosharecache might be the best thing to do, but since I am now able to
> use the latest kernel, I am very happy already.

Actually, I think just fine-tuning it a bit may be better:

1. make 'nosharecache' as default
2. apply the algorithm in this patch to 'nosharecache': if the fsid and
mount options are the same, then share cache

This way the default behavior does not change, but both algorithms have
pitfalls, and we choose from:
1. if user specifies "sharecache", he may end up with nosharecache if mount
options are different
And
2. if user specifies "nosharecache", he may end up with sharecache if mount
options are the same

I'd think 2 is better (least surprise). I cannot think of a case where 2 is
actually a bad thing.

Comments?

> Thanks a lot for your attention to my problem. :-)
> 
> > Trond

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/