linux-kernel - Re: [PATCH] x86/x86-64 PCI domain support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46D9E254.6010702@garzik.org>
Date:	Sat, 01 Sep 2007 18:06:12 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Andi Kleen <ak@...e.de>
CC:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] x86/x86-64 PCI domain support

Andi Kleen wrote:
>>  
>> +config PCI_DOMAINS
>> +	bool "PCI domain support"
>> +	depends on PCI
> 
> I don't think this should be a config option.

CONFIG_PCI_DOMAINS is referenced in arch-neutral code, so the symbol 
_must_ be defined.

It can be hidden, perhaps, if that makes our x86 maintainer happy :)


> But there should be a pci=... option with Documentation to turn it off at runtime

OK


>> +static inline int pci_proc_domain(struct pci_bus *bus)
>> +{
>> +	return pci_domain_nr(bus);
>> +}
> 
> The second function is redundant? 

No, it's a hook we must implement, when CONFIG_PCI_DOMAINS is enabled.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/