linux-kernel - Re: [RFC + PATCH] signalfd simplification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070902130234.GA183@tv-sign.ru>
Date:	Sun, 2 Sep 2007 17:02:34 +0400
From:	Oleg Nesterov <oleg@...sign.ru>
To:	Davide Libenzi <davidel@...ilserver.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Michael Kerrisk <mtk-manpages@....net>
Subject: Re: [RFC + PATCH] signalfd simplification

On 09/02, Oleg Nesterov wrote:
>
> Small problem: unless I missed something, signalfd_deliver() and sys_signalfd()
> should use wake_up_all(), not wake_up() which implies nr_exclusive == 1.
> 
> It is possible that we have multiple threads waiting on ->signalfd_wqh with
> the the different ->sigmask. In this case, the first woken thread can ignore
> the signal, we should wake up all of them.

Oops, sorry for noise. I forgot about WQ_FLAG_EXCLUSIVE, we don't set it by
default.

Oleg.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/