linux-kernel - Re: [PATCH] Blackfin BF54x NAND Flash Controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1188837990.6075.32.camel@shinybook.infradead.org>
Date:	Mon, 03 Sep 2007 17:46:30 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	bryan.wu@...log.com
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH] Blackfin BF54x NAND Flash Controller driver

On Mon, 2007-09-03 at 15:25 +0800, Bryan Wu wrote:
> +       if (hardware_ecc) {
> +               if (plat->page_size == NFC_PG_SIZE_256) {
> +                       chip->ecc.bytes = 3;
> +                       chip->ecc.size = 256;
> +               } else if (mtd->writesize == NFC_PG_SIZE_512) { 

Comparing against plat->page_size in one case, but mtd->writesize in the
other? And elsewhere it seems plat->page_size is treated as a boolean,
indicating only 256-byte vs. 512-byte pages (you don't support 2KiB or
other page sizes at all?)

-- 
dwmw2

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/