[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <46DC6446.1080707@linux.vnet.ibm.com>
Date: Mon, 03 Sep 2007 20:45:10 +0100
From: Balbir Singh <balbir@...ux.vnet.ibm.com>
To: Paul Menage <menage@...gle.com>
CC: Andrew Morton <akpm@...ux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Linux Containers <containers@...ts.osdl.org>,
Linux MM Mailing List <linux-mm@...ck.org>,
David Rientjes <rientjes@...gle.com>,
Dave Hansen <haveblue@...ibm.com>
Subject: Re: [-mm PATCH] Memory controller improve user interface (v3)
Paul Menage wrote:
> On 9/2/07, Balbir Singh <balbir@...ux.vnet.ibm.com> wrote:
>> - s += sprintf(s, "%lu\n", *val);
>> + if (read_strategy)
>> + s += read_strategy(*val, s);
>> + else
>> + s += sprintf(s, "%lu\n", *val);
>
> This would be better as %llu
>
>> + tmp = simple_strtoul(buf, &end, 10);
>
> and this as simple_strtoull()
>
> Paul
>
Thanks for catching it, I'll fix that.
--
Warm Regards,
Balbir Singh
Linux Technology Center
IBM, ISTL
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists