[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <46DD13CE.6010905@gmail.com>
Date: Tue, 04 Sep 2007 16:14:06 +0800
From: Micah Gruber <micah.gruber@...il.com>
To: linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
jgarzik@...ox.com
Subject: [CORRECTION][PATCH] Fix a potential NULL pointer dereference in uli526x_interrupt()
in drivers/net/tulip/uli526x.c
This patch fixes a potential null dereference bug where we dereference dev before a null check. This patch simply moves the dereferencing after the null check.
Signed-off-by: Micah Gruber <micah.gruber@...il.com>
---
--- a/drivers/net/tulip/uli526x.c
+++ b/drivers/net/tulip/uli526x.c
@@ -663,7 +663,7 @@
{
struct net_device *dev = dev_id;
struct uli526x_board_info *db = netdev_priv(dev);
- unsigned long ioaddr = dev->base_addr;
+ unsigned long ioaddr;
unsigned long flags;
if (!dev) {
@@ -671,6 +671,8 @@
return IRQ_NONE;
}
+ ioaddr = dev->base_addr;
+
spin_lock_irqsave(&db->lock, flags);
outl(0, ioaddr + DCR7);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists