linux-kernel - Re: [PATCH 2/2] Fix (improve) deadlock condition on module removal netfilter socket option removal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1189032069.10802.212.camel@localhost.localdomain>
Date:	Thu, 06 Sep 2007 08:41:09 +1000
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Jon Masters <jonathan@...masters.org>
Cc:	Neil Horman <nhorman@...driver.com>, adam@...drasil.com,
	jcm@...masters.org, kaber@...sh.net,
	netfilter-devel@...ts.netfilter.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] Fix (improve) deadlock condition on module removal
	netfilter socket option removal

On Wed, 2007-09-05 at 16:26 -0400, Jon Masters wrote:
> On Tue, 2007-09-04 at 16:30 -0400, Neil Horman wrote:
> 
> > 	2nd of two patches.  This patch enhances modprobe to operate like rmmod
> > in non-blocking mode.  It also adds a -w option to allow for explicit blocking
> > operation.
> 
> As I suspected, this patch isn't in the tree. I am going to commit it
> now because it makes sense. I'm also going to sort out moving things to
> kernel.org this afternoon while I'm at it - I don't want to confuse
> people with kerneltools.org any more now I've got a kernel.org acc.

1) You don't want to hand the "wait" flag (ie ~O_NONBLOCK) to
sub-rmmods,

2) You need to do something about this code if wait is specified:

	if (usecount != 0) {
		if (!ignore_inuse)
			error("Module %s is in use.\n", name);
		goto remove_rest;
	}

Cheers,
Rusty.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/