linux-kernel - Re: [PATCH][RFC] pte notifiers -- support for external page tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46DFFE1F.7060900@qumranet.com>
Date:	Thu, 06 Sep 2007 16:18:23 +0300
From:	Avi Kivity <avi@...ranet.com>
To:	Andi Kleen <andi@...stfloor.org>
CC:	Avi Kivity <public-avi-atKUWr5tajBWk0Htik3J/w@...o.gmane.org>,
	public-linux-kernel-u79uwXL29TY76Z2rM5mHXA@...o.gmane.org,
	public-linux-mm-Bw31MaZKKs3YtjvyW6yDsg@...o.gmane.org,
	public-kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@...o.gmane.org,
	public-general-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@...o.gmane.org
Subject: Re: [PATCH][RFC] pte notifiers -- support for external page	tables




[ugh, what happened to the cc-list?]

Andi Kleen wrote:
> Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@...lic.gmane.org> writes:
>   
>> pte notifiers are different from paravirt_ops: they extend the normal
>> page tables rather than replace them; and they provide high-level information
>> such as the vma and the virtual address for the driver to use.
>>     
>
> Sounds like a locking horror to me.  To do anything with page tables
> you need locks. Both for the kernel page tables and for your new tables.
>
> What happens when people add all
> things of complicated operations in these notifiers? That will likely
> happen and then everytime you change something in VM code they 
> will break. This has the potential to increase the cost of maintaining
> VM code considerably, which would be a bad thing.
>
> This is quite different from paravirt ops because low level pvops
> can typically run lockless by just doing some kind of hypercall directly.
> But that won't work for maintaining your custom page tables.
>   

This is a real problem.  I don't have a solution yet.

Obviously that needs to be addressed before something like this can go 
in; but as it's been done for the quadrics driver, presumably it is doable.

-- 
Any sufficiently difficult bug is indistinguishable from a feature.



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/