linux-kernel - Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070906013929.1621849d@the-village.bc.nu>
Date:	Thu, 6 Sep 2007 01:39:29 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Mikael Pettersson <mikpe@...uu.se>
Cc:	Jeff Norden <jeff@...h.tntech.edu>, alan@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] pata_it821x: fix lost interrupt with atapi devices

/from the media. */
>  > +	if (qc->nbytes < 2048)
>  > +		return -EOPNOTSUPP;
>  > +
>  >  	/* No ATAPI DMA in smart mode */
>  >  	if (itdev->smart)
>  >  		return -EOPNOTSUPP;
>  > 
> 
> This looks like a gross hack. Aren't you supposed to inspect
> the command instead and whitelist the ones you know are OK,
> like pata_pdc2027x.c and sata_promise.c do?

It does seem to be about transfer size in the IT821x case not commands.
It may be to do with how we issue ATAPI command transfer sizes from high
up (patch went to Jeff) but for now this is definitely the right approach

Reviewed-by: Alan Cox <alan@...hat.com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/