linux-kernel - Re: 4096 byte limit to /proc/PID/environ ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46DFF3BC.6060104@zytor.com>
Date:	Thu, 06 Sep 2007 13:34:04 +0100
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Jan Engelhardt <jengelh@...putergmbh.de>
CC:	James Pearson <james-p@...ing-picture.com>,
	Anton Arapov <aarapov@...hat.com>,
	Guy Streeter <guy.streeter@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: 4096 byte limit to /proc/PID/environ ?

Jan Engelhardt wrote:
> On Sep 5 2007 18:00, James Pearson wrote:
>> OK, here is the patch (without the long line) against 2.6.23-rc5 - what else
>> needs to be done to get it committed?
> 
> Someone has to point out CodingStyle, so I'll ruin everyone's day now :)
> 
>> +static ssize_t environ_read(struct file * file, char __user * buf,
>                                             ^                   ^
> be gone these spaces.
> 
>> +       while (count > 0) {
>> +               int this_len, retval;
>> +
>> +               this_len = mm->env_end - (mm->env_start + src);
>> +
>> +               if (this_len <= 0) {
>> +                       break;
>> +               }
> 
> Be gone, braces.
> 

Right, also please use use checkpatch.pl.

	-hpa

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/