lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 7 Sep 2007 16:01:59 +0530 From: Ananth N Mavinakayanahalli <ananth@...ibm.com> To: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca> Cc: akpm@...ux-foundation.org, linux-kernel@...r.kernel.org, Christoph Hellwig <hch@...radead.org>, prasanna@...ibm.com, anil.s.keshavamurthy@...el.com, davem@...emloft.net Subject: Re: [patch 4/8] Immediate Values - Move Kprobes i386 restore_interrupt to kdebug.h On Thu, Sep 06, 2007 at 04:02:32PM -0400, Mathieu Desnoyers wrote: > Since the breakpoint handler is useful both to kprobes and immediate values, it > makes sense to make the required restore_interrupt() available through > asm-i386/kdebug.h. > > Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca> Acked-by: Ananth N Mavinakayanahalli <ananth@...ibm.com> > CC: Christoph Hellwig <hch@...radead.org> > CC: prasanna@...ibm.com > CC: ananth@...ibm.com > CC: anil.s.keshavamurthy@...el.com > CC: davem@...emloft.net > --- > include/asm-i386/kdebug.h | 12 ++++++++++++ > include/asm-i386/kprobes.h | 9 --------- > 2 files changed, 12 insertions(+), 9 deletions(-) > > Index: linux-2.6-lttng/include/asm-i386/kdebug.h > =================================================================== > --- linux-2.6-lttng.orig/include/asm-i386/kdebug.h 2007-09-04 11:52:37.000000000 -0400 > +++ linux-2.6-lttng/include/asm-i386/kdebug.h 2007-09-04 12:12:06.000000000 -0400 > @@ -6,6 +6,9 @@ > * from x86_64 architecture. > */ > > +#include <asm/ptrace.h> > +#include <asm/system.h> > + > struct pt_regs; > > /* Grossly misnamed. */ > @@ -25,4 +28,13 @@ enum die_val { > DIE_PAGE_FAULT_NO_CONTEXT, > }; > > +/* trap3/1 are intr gates for kprobes. So, restore the status of IF, > + * if necessary, before executing the original int3/1 (trap) handler. > + */ > +static inline void restore_interrupts(struct pt_regs *regs) > +{ > + if (regs->eflags & IF_MASK) > + local_irq_enable(); > +} > + > #endif > Index: linux-2.6-lttng/include/asm-i386/kprobes.h > =================================================================== > --- linux-2.6-lttng.orig/include/asm-i386/kprobes.h 2007-09-04 11:53:26.000000000 -0400 > +++ linux-2.6-lttng/include/asm-i386/kprobes.h 2007-09-04 12:12:06.000000000 -0400 > @@ -79,15 +79,6 @@ struct kprobe_ctlblk { > struct prev_kprobe prev_kprobe; > }; > > -/* trap3/1 are intr gates for kprobes. So, restore the status of IF, > - * if necessary, before executing the original int3/1 (trap) handler. > - */ > -static inline void restore_interrupts(struct pt_regs *regs) > -{ > - if (regs->eflags & IF_MASK) > - local_irq_enable(); > -} > - > extern int kprobe_exceptions_notify(struct notifier_block *self, > unsigned long val, void *data); > extern int kprobe_fault_handler(struct pt_regs *regs, int trapnr); > > -- > Mathieu Desnoyers > Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal > OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists