| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20070908182928.5AEAA402B15@smtp03.mtu.ru>
Date: Sat, 08 Sep 2007 22:29:27 +0400
From: Andrey Borzenkov <arvidjaar@...l.ru>
To: Anssi Hannula <anssi.hannula@...il.com>,
linux-kernel@...r.kernel.org, Dmitry Torokhov <dtor@...ightbb.com>,
linux-input@...ey.karlin.mff.cuni.cz,
linux-hotplug-devel@...ts.sourceforge.net
Subject: Re: sysfs change of input/event devices in 2.6.23rc breaks udev
Anssi Hannula wrote:
> Hi!
>
> There seem to be changes in sysfs input structure between 2.6.22 and
> 2.6.23-rc5 which cause some breakage.
>
I'm running 2.6.23-rc5 in up-to-date cooker.
> With 2.6.22:
>
>> # LC_ALL=C ls -l /sys/class/input/input4
>> total 0
>> drwxr-xr-x 2 root root 0 Sep 8 12:51 capabilities/
>> lrwxrwxrwx 1 root root 0 Sep 8 19:48 device ->
>> ../../../devices/platform/pcspkr/
>> drwxr-xr-x 2 root root 0 Sep 8 12:51 event4/
>> drwxr-xr-x 2 root root 0 Sep 8 12:51 id/
>> -r--r--r-- 1 root root 4096 Sep 8 19:48 modalias
>> -r--r--r-- 1 root root 4096 Sep 8 19:48 name
>> -r--r--r-- 1 root root 4096 Sep 8 19:48 phys
>> lrwxrwxrwx 1 root root 0 Sep 8 19:48 subsystem ->
>> ../../../class/input/
>> --w------- 1 root root 4096 Sep 8 19:48 uevent
>> -r--r--r-- 1 root root 4096 Sep 8 19:48 uniq
>
>> # ls -l /sys/class/input/event4
>> lrwxrwxrwx 1 root root 0 Sep 8 19:48 /sys/class/input/event4 ->
>> ../../class/input/input4/event4/
>> # ls -l /sys/class/input/event4/
>> total 0
>> -r--r--r-- 1 root root 4096 Sep 8 19:58 dev
>> lrwxrwxrwx 1 root root 0 Sep 8 19:58 device ->
>> ../../../../devices/platform/pcspkr/
>> lrwxrwxrwx 1 root root 0 Sep 8 19:58 subsystem ->
>> ../../../../class/input/
>> --w------- 1 root root 4096 Sep 8 19:58 uevent
>
> With 2.6.23-rc5:
>
>> # ls -l /sys/class/input/input5
>> total 0
>> drwxr-xr-x 2 root root 0 Sep 8 19:47 capabilities/
>> lrwxrwxrwx 1 root root 0 Sep 8 19:03 device ->
>> ../../../devices/platform/pcspkr/
>> drwxr-xr-x 2 root root 0 Sep 8 19:47 id/
>> lrwxrwxrwx 1 root root 0 Sep 8 19:47 input:event5 ->
>> ../../../class/input/event5/
I do not have this
>> -r--r--r-- 1 root root 4096 Sep 8 19:03 modalias
>> -r--r--r-- 1 root root 4096 Sep 8 19:03 name
>> -r--r--r-- 1 root root 4096 Sep 8 19:47 phys
>> drwxr-xr-x 2 root root 0 Sep 8 19:47 power/
>> lrwxrwxrwx 1 root root 0 Sep 8 19:03 subsystem ->
>> ../../../class/input/
>> -rw-r--r-- 1 root root 4096 Sep 8 19:03 uevent
>> -r--r--r-- 1 root root 4096 Sep 8 19:47 uniq
>
>> # ls -l /sys/class/input/event5
>> total 0
>> -r--r--r-- 1 root root 4096 Sep 8 19:03 dev
>> lrwxrwxrwx 1 root root 0 Sep 8 19:03 device ->
>> ../../../class/input/input5/
>> drwxr-xr-x 2 root root 0 Sep 8 19:48 power/
>> lrwxrwxrwx 1 root root 0 Sep 8 19:03 subsystem ->
>> ../../../class/input/
>> -rw-r--r-- 1 root root 4096 Sep 8 19:03 uevent
>
> There are a few changes.
>
> There is no longer:
> /sys/class/input/eventX => /sys/class/input/inputX/eventX
> instead there is:
> /sys/class/inputX/input:eventX => /sys/class/input/eventX
> Notice the added "input:". I don't know if any software depends on this,
> though.
>
> However, the change that broke id_path of udev is that
> /sys/class/input/event5/device is now a symlink to the inputX directory
> instead of being the same as the device symlink in inputX directory,
> i.e. to ../../../devices/platform/pcspkr in this case.
>
> Udev id_path uses that directory to construct the ID_PATH variable.
> Should the sysfs structure be reverted or should udev be adapted to
> handle traversing /device symlink twice? I think the former, as there
> should be considerably more time to adapt udev for coming changes in
> sysfs.
>
I am using 2.6.23-rc5 in current cooker and I did not notice any breakage;
could you please show example of wrong path? E.g. I have
{pts/0}% LC_ALL=C ll /dev/input/by-path
total 0
lrwxrwxrwx 1 root root 9 Sep 2 15:00
platform-i8042-serio-0-event-kbd -> ../event0
lrwxrwxrwx 1 root root 9 Sep 2 15:00
platform-i8042-serio-1-event-mouse -> ../event1
lrwxrwxrwx 1 root root 9 Sep 2 15:00
platform-i8042-serio-1-mouse -> ../mouse0
and it looks pretty sane for me.
Oh, and I do not have CONFIG_SYSFS_DEPRECATED which probably explains why it
works for me :)
{pts/0}% LC_ALL=C ll /sys/class/input/input2/
total 0
drwxr-xr-x 2 root root 0 Sep 8 22:25 capabilities/
drwxr-xr-x 3 root root 0 Sep 8 22:22 event2/
drwxr-xr-x 2 root root 0 Sep 8 22:25 id/
-r--r--r-- 1 root root 4096 Sep 8 22:25 modalias
-r--r--r-- 1 root root 4096 Sep 8 22:25 name
-r--r--r-- 1 root root 4096 Sep 8 22:25 phys
drwxr-xr-x 2 root root 0 Sep 8 22:25 power/
lrwxrwxrwx 1 root root 0 Sep 8 22:25
subsystem -> ../../../../class/input/
-rw-r--r-- 1 root root 4096 Sep 8 22:25 uevent
-r--r--r-- 1 root root 4096 Sep 8 22:25 uniq
this implies that SYSFS_DEPRECATED may be broken w.r.t. udev; OTOH it *is*
deprecated, is not it?
-andrey
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists