linux-kernel - Re: sata & scsi suggestion for make menuconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200709081703.31280.a1426z@gawab.com>
Date:	Sat, 8 Sep 2007 17:03:31 +0300
From:	Al Boldi <a1426z@...ab.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: sata & scsi suggestion for make menuconfig

Alan Cox wrote:
> > I once sent a patch to make libata a submenu of scsi.
>
> Which is wrong
>
> Nakked-by: Alan Cox <alan@...hat.com>
>
> The general comments about moving this stuff around and making it clearer
> what sd/sr etc are nowdays are good but hiding libata under SCSI will
> cause even more confusion than it cures

That's easy to fix:  just change the SCSI heading to include a libata hint.

Something like this:

[PATCH] libata Kconfig: Allow libata to be selected from within the SCSI submenu

Move libata Kconfig sourcing from the drivers Kconfig into the SCSI Kconfig,
and change the SCSI menu heading to indicate libata submenu inclusion.

This allows the user to quickly select additional disk/tape/cdrom support 
from within the same menu.

Signed-off-by: Al Boldi <a1426z@...ab.com>
Cc: Alan Cox <alan@...rguk.ukuu.org.uk>
---
--- a/drivers/Kconfig   2007-05-02 17:25:30.000000000 +0300
+++ b/drivers/Kconfig   2007-08-01 06:33:13.000000000 +0300
@@ -22,8 +22,6 @@ source "drivers/ide/Kconfig"
 
 source "drivers/scsi/Kconfig"
 
-source "drivers/ata/Kconfig"
-
 source "drivers/cdrom/Kconfig"
 
 source "drivers/md/Kconfig"
--- a/drivers/scsi/Kconfig      2007-07-09 06:38:37.000000000 +0300
+++ b/drivers/scsi/Kconfig      2007-08-01 06:46:42.000000000 +0300
@@ -7,6 +7,8 @@ config RAID_ATTRS
        ---help---
          Provides RAID
 
+source "drivers/ata/Kconfig"
+
 config SCSI
-       tristate "SCSI device support"
+       tristate "SCSI and Libata device support"
        depends on BLOCK



Thanks!

--
Al
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/