linux-kernel - [PATCH] KCONFIG: fix pseudo dependency between K8_NUMA and X86_64_ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 09 Sep 2007 09:19:05 -0400
From:	"James C. Georgas" <jgeorgas@...rgas.ca>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Randy Dunlap <randy.dunlap@...cle.com>,
	linux-kernel@...r.kernel.org
Subject: [PATCH] KCONFIG: fix pseudo dependency between K8_NUMA and
	X86_64_ACPI_NUMA config options

On Sun, 2007-09-09 at 11:07 +0200, Andi Kleen wrote:
> "James C. Georgas" <jgeorgas@...rgas.ca> writes:
> > 
> > It's 2.6.22.6. I'm thinking a fix would be to add "select PM" to
> > X86_64_ACPI_NUMA.
> > 
> > I'm also thinking that maybe K8_NUMA should be changed from "depends on
> > PCI" to "select PCI", like X86_64_ACPI_NUMA is. That would fix the
> > pseudo dependency they have between them (i.e. selecting
> > X86_64_ACPI_NUMA causes PCI to be selected, which then makes K8_NUMA
> > visible, because its PCI dependency is now satisfied).
> 
> Sounds reasonable. Can you please submit a tested patch with proper
> description and Signed-off-by lines?
> 
> -Andi

How's this?


>>From 6febbd64aaca5d54487d8f9df4949001e0fc4ec6 Mon Sep 17 00:00:00 2001
From: James C. Georgas <jgeorgas@...rgas.ca>
Date: Sun, 9 Sep 2007 08:27:46 -0400
Subject: [PATCH] Signed-off-by: James C. Georgas <jgeorgas@...rgas.ca>

Changed K8_NUMA from "depends on PCI" to "select PCI", like X86_64_ACPI_NUMA is. This fixes the pseudo dependency between X86_64_ACPI_NUMA and K8_NUMA (i.e. selecting X86_64_ACPI_NUMA would cause PCI to be selected, which then made K8_NUMA visible, because its PCI dependency was now satisfied).
---
 arch/x86_64/Kconfig |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/arch/x86_64/Kconfig b/arch/x86_64/Kconfig
index ffa0364..bdeeb25 100644
--- a/arch/x86_64/Kconfig
+++ b/arch/x86_64/Kconfig
@@ -357,7 +357,8 @@ config NUMA
 
 config K8_NUMA
        bool "Old style AMD Opteron NUMA detection"
-       depends on NUMA && PCI
+       depends on NUMA
+       select PCI
        default y
        help
         Enable K8 NUMA node topology detection.  You should say Y here if
-- 
1.5.1.6


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/