linux-kernel - Re: [SYSFS - 2.6.23-rc5-git1 ] device_rename: sysfs_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070910133006.26ddfdab@gondolin.boeblingen.de.ibm.com>
Date:	Mon, 10 Sep 2007 13:30:06 +0200
From:	Cornelia Huck <cornelia.huck@...ibm.com>
To:	Daniel Lezcano <dlezcano@...ibm.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [SYSFS - 2.6.23-rc5-git1 ] device_rename: sysfs_create_symlink
 failed (-17)

On Fri, 07 Sep 2007 16:14:12 +0200,
Daniel Lezcano <dlezcano@...ibm.com> wrote:

> Hi,
> 
> when using the 2.6.23-rc5-git1 kernel and trying to change a network 
> device name, I have the following error:
> 
> device_rename: sysfs_create_symlink failed (-17)

-EEXIST, maybe a double rename?

> 
> That comes from drivers/base/core.c : 1261

This is the link under the class directory to the renamed device.

> 
> I know anything about sysfs, so no much help to give... :(
> 
> I don't know if this is a bug, but my code use device_rename, check the 
> return value and fails. I will ignore it, but it seems not to be a 
> correct behavior to have such error.

Why does your code need to call device_rename() itself, I'd have
thought the networking code took care of it? (BTW: Which driver?)

> 
> Easy to reproduce:
> 	load a dummy network driver => dummy0
> 	change its name with : ip link set name foo0 dev dummy0

[Don't know if ip is sensitive to order, but shouldn't that be
ip link set dev dummy0 name foo0 ?]

You could try to switch on DEBUG_DRIVER and DEBUG_KOBJECT, this may
point to where the double name pops up. 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/