[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <46E53D96.4050409@qumranet.com>
Date: Mon, 10 Sep 2007 15:50:30 +0300
From: Avi Kivity <avi@...ranet.com>
To: Ingo Molnar <mingo@...e.hu>
CC: Laurent Vivier <Laurent.Vivier@...l.net>,
linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND][PATCH 0/4] Virtual Machine Time Accounting
Ingo Molnar wrote:
> * Laurent Vivier <Laurent.Vivier@...l.net> wrote:
>
>
>> Ingo, please, could you have a look to these patches ?
>>
>> The aim of these four patches is to introduce Virtual Machine time
>> accounting.
>>
>> [PATCH 1/4] as recent CPUs introduce a third running state, after
>> "user" and "system", we need a new field, "guest", in cpustat to store
>> the time used by the CPU to run virtual CPU. Modify /proc/stat to
>> display this new field.
>>
>
> the concept certainly looks sane to me.
>
> The heavy-handed use of #ifdefs uglifies the code to a large degree, but
> this is not a fundamental problem: since basically all distros have KVM
> enabled (and lguest benefits from this too), could you just make all
> this new code unconditional?
>
I imagine the embedded people will complain... perhaps move all the code
to a #ifdef section above with a full implementation and a stub
implementation.
--
error compiling committee.c: too many arguments to function
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists