linux-kernel - Re: 2.6.23-rc3-mm1 - vdso and gettimeofday issues with glibc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5026.1189451250@turing-police.cc.vt.edu>
Date:	Mon, 10 Sep 2007 15:07:30 -0400
From:	Valdis.Kletnieks@...edu
To:	Andi Kleen <ak@...e.de>
Cc:	Chuck Ebbert <cebbert@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>, jakub@...hat.com,
	Ulrich Drepper <drepper@...hat.com>,
	linux-kernel@...r.kernel.org
Subject: Re: 2.6.23-rc3-mm1 - vdso and gettimeofday issues with glibc

On Sun, 09 Sep 2007 09:27:06 +0200, Andi Kleen said:
> > Updating on this issue:   Both myself and another person have reported on
> > the RedHat bugzilla that it's a clocksource issue - if you are using the
> > hpet clocksource, the time warps, but booting with clocksource=acpi_pm works.
> > 
> > This ring any bells?
> 
> Does this patch fix it? 
> -Andi
> 
> Add missing mask operation to vdso
> 
> vdso vgetns() didn't mask the time source offset calculation, which could
> lead to time problems with 32bit HPET. Add the masking.
> 
> Thanks to Chuck Ebbert for tracking down.
> 
> Signed-off-by: Andi Kleen <ak@...e.de>

Confirming that does indeed fix it - booted with hpet clocksource and vdso=1,
and the time didn't warp at the 5-minute mark.

Tested-By: Valdis Kletnieks <valdis.kletnieks@...edu>

Content of type "application/pgp-signature" skipped