linux-kernel - Re: [-mm patch] mm/memcontrol.c: clenups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0709102159270.5368@fbirervta.pbzchgretzou.qr>
Date:	Mon, 10 Sep 2007 21:59:57 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...putergmbh.de>
To:	Balbir Singh <balbir@...ux.vnet.ibm.com>
cc:	Adrian Bunk <bunk@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [-mm patch] mm/memcontrol.c: clenups


On Sep 10 2007 21:58, Jan Engelhardt wrote:
>On Sep 10 2007 13:53, Balbir Singh wrote:
>>> --- a/mm/memcontrol.c
>>> +++ b/mm/memcontrol.c
>>> @@ -91,7 +91,7 @@ enum {
>>>  	MEM_CONTAINER_TYPE_CACHED,
>>>  	MEM_CONTAINER_TYPE_ALL,
>>>  	MEM_CONTAINER_TYPE_MAX,
>>> -} mem_control_type;
>>> +};
>>
>>Not sure about this, is this the preferred style?

Humm. Judging from the @@-line, it looks like:

enum {
	MEM_CONTAINER_TYPE_WHATEVER
} mem_control_type;

making it actually a variable name. Confusing at best.


	Jan
-- 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/