linux-kernel - Re: [RFC 0/3] Recursive reclaim (on __PF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1189457286.21778.68.camel@twins>
Date:	Mon, 10 Sep 2007 22:48:06 +0200
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Christoph Lameter <clameter@....com>
Cc:	Daniel Phillips <phillips@...nq.net>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	dkegel@...gle.com, David Miller <davem@...emloft.net>,
	Nick Piggin <npiggin@...e.de>
Subject: Re: [RFC 0/3] Recursive reclaim (on __PF_MEMALLOC)

On Mon, 2007-09-10 at 13:22 -0700, Christoph Lameter wrote:
> On Mon, 10 Sep 2007, Peter Zijlstra wrote:
> 
> > On Mon, 2007-09-10 at 12:25 -0700, Christoph Lameter wrote:
> > 
> > > Of course boundless allocations from interrupt / reclaim context will 
> > > ultimately crash the system. To fix that you need to stop the networking 
> > > layer from performing these.
> > 
> > Trouble is, I don't only need a network layer to not endlessly consume
> > memory, I need it to 'fully' function so that we can receive the
> > writeout completion.
> 
> You need to drop packets after having inspected them right? Why wont 
> dropping packets after a certain amount of memory has been allocated work? 
> What is so difficult about that?

That puts the burden of tracking skb allocations and all that on the
fast path.

The 'simplicity' of my current approach is that we only start
bean-counting (and incur the overhead thereof) once we need it.

> > or
> > 
> >   - have a global reserve and selectively serves sockets
> >     (what I've been doing)
> 
> That is a scalability problem on large systems! Global means global 
> serialization, cacheline bouncing and possibly livelocks. If we get into 
> this global shortage then all cpus may end up taking the same locks 
> cycling thought the same allocation paths.

Dude, breathe, these boxens of yours will never swap over network simply
because you never configure swap. 

And, _no_, it does not necessarily mean global serialisation. By simply
saying there must be N pages available I say nothing about on which node
they should be available, and the way the watermarks work they will be
evenly distributed over the appropriate zones.

> > So, if you will, you can view my approach as a reserve per socket, where
> > most sockets get a reserve of 0 and a few (those serving the VM) !0.
> 
> Well it looks like you know how to do it. Why not implement it?

/me confused, I already have!

If you talk about the IRIX model, I'm very hestitant to do that simply
because that would incur the bean-counting overhead on the normal case
and that will greatly upset the network people - nor would that mean
that I don't need this stricter PF_MEMALLOC behaviour.

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)