[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <s5hejh6qkiu.wl%tiwai@suse.de>
Date: Mon, 10 Sep 2007 23:26:49 +0200
From: Takashi Iwai <tiwai@...e.de>
To: "Adrian McMenamin" <adrianmcmenamin@...il.com>
Cc: alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
linuxsh-dev@...ts.sourceforge.net, Paul Mundt <lethal@...ux-sh.org>
Subject: Re: [alsa-devel] [PATCH] Patch Dreamcast AICA driver to handle Maple bus support
At Sun, 9 Sep 2007 21:22:17 +0100,
Adrian McMenamin wrote:
>
> @@ -218,6 +219,12 @@ static int aica_dma_transfer(int channels, int buffer_size,
> period_offset = dreamcastcard->clicks;
> period_offset %= (AICA_PERIOD_NUMBER / channels);
> runtime = substream->runtime;
> + /* If maple dma is running, wait for it to finish */
> + do{ cpu_relax();}
> + while (!maple_dma_done());
This coding style is ugly. Could you fix?
Takashi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists