linux-kernel - Re: [RFC] kbuild - introduce vdir to make life easier for x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200709110040.41605.ak@suse.de>
Date:	Tue, 11 Sep 2007 00:40:41 +0200
From:	Andi Kleen <ak@...e.de>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	LKML <linux-kernel@...r.kernel.org>,
	kbuild devel <kbuild-devel@...ts.sourceforge.net>
Subject: Re: [RFC] kbuild - introduce vdir to make life easier for x86_64

> The below are the minimal clean-up - a bit more could be done.
> 
> Comments?

Looks good in principle. My only suggestion would be to name it something
differently than vdir. I know that's what GNU make calls it, but it's still
pretty cryptic. How about just fallback-dir ? 

Also what would be nice (I don't know if it's doable in make) would
be a separate variable (e.g. other-obj-... := ) that contains the fallback
names and that is double checked against the fallback directory. That
would document it clearly what's going on. Failing that stuffing 
them into a comment would be good at least.

-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/