linux-kernel - Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Sep 2007 11:38:48 +0200
From:	Laurent Vivier <Laurent.Vivier@...l.net>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [RESEND 2][PATCH 0/4] Virtual Machine Time Accounting

Ingo Molnar wrote:
> * Laurent Vivier <Laurent.Vivier@...l.net> wrote:
> 
>> This new version remove conditional compilation on GUEST_ACCOUNTING.
> 
> excellent! For all 4 patches:
> 
>  Acked-by: Ingo Molnar <mingo@...e.hu>
> 
> i'd suggest inclusion into 2.6.24.

Thank you.

> can the /proc change break anything? Any old procps version perhaps?

I've tested top and ps from procps 3.0.5, 3.1.8, 3.1.14, 3.2.1 and 3.2.7 without
any problem.

And as values are read with a sscanf() by procps, I think adding a field at the
end of the  line is not a problem.

For those who want to play, I've attached a patch to procps-3.2.7 to display
guest time in top.

Regards,
Laurent
-- 
------------- Laurent.Vivier@...l.net  --------------
          "Software is hard" - Donald Knuth

View attachment "stat_guest" of type "text/plain" (4717 bytes)

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)