linux-kernel - RE: [PATCH 5/5] Add DMA engine driver for Freescale MPC85xx processors.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Sep 2007 18:10:53 +0800
From:	"Zhang Wei-r63237" <Wei.Zhang@...escale.com>
To:	"Nelson, Shannon" <shannon.nelson@...el.com>, <paulus@...ba.org>
Cc:	<linux-kernel@...r.kernel.org>, <linuxppc-dev@...abs.org>,
	<galak@...nel.crashing.org>,
	"Zhu Ebony-r57400" <ebony.zhu@...escale.com>,
	<dan.j.williams@...el.com>
Subject: RE: [PATCH 5/5] Add DMA engine driver for Freescale MPC85xx processors.

> 
> If this is experimental, perhaps you should mark the depends line as
> such
> 	depends on on DMA_ENGINE && PPC && EXPERIMENTAL

I'll add EXPERIMENTAL for MPC83xx only.

> 
> [...]
> 
> >+
> >+	fsl_dma_memcpy_issue_pending(chan);
> >+	while (fsl_dma_is_complete(chan, cookie, NULL, NULL)
> >+			!= DMA_SUCCESS);
> 
> Again, is it possible to hang your thread here?
> 
> [...]

I'll add msleep here.

Thanks!

- zw
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/