linux-kernel - RE: [PATCH 5/5] Add DMA engine driver for Freescale MPC85xx processors.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Sep 2007 08:15:30 -0700
From:	"Nelson, Shannon" <shannon.nelson@...el.com>
To:	"Scott Wood" <scottwood@...escale.com>,
	"Zhang Wei-r63237" <Wei.Zhang@...escale.com>
Cc:	<paulus@...ba.org>, <linuxppc-dev@...abs.org>,
	"Williams, Dan J" <dan.j.williams@...el.com>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 5/5] Add DMA engine driver for Freescale MPC85xx processors.

>From: Scott Wood [mailto:scottwood@...escale.com] 
>Sent: Tuesday, September 11, 2007 7:20 AM
>To: Zhang Wei-r63237
>Cc: Nelson, Shannon; paulus@...ba.org; 
>linuxppc-dev@...abs.org; Williams, Dan J; linux-kernel@...r.kernel.org
>Subject: Re: [PATCH 5/5] Add DMA engine driver for Freescale 
>MPC85xx processors.
>
>On Tue, Sep 11, 2007 at 06:10:53PM +0800, Zhang Wei-r63237 wrote:
>> > >+
>> > >+	fsl_dma_memcpy_issue_pending(chan);
>> > >+	while (fsl_dma_is_complete(chan, cookie, NULL, NULL)
>> > >+			!= DMA_SUCCESS);
>> > 
>> > Again, is it possible to hang your thread here?
>> > 
>> > [...]
>> 
>> I'll add msleep here.
>
>I think what was being sought was a timout, causing the test to return
>failure.
>
>-Scott
>

Either a timeout to stop the polling, or msleep() followed by a single
call to fsl_dma_is_complete().  However, using the msleep() method is
likely to be kinder to the rest of the kernel than polling for very
long.

sln
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/