linux-kernel - Re: [PATCH] leds: add #include <linux/spinlock_types.h> to include/linux/leds.h for rwlock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070910220423.43e0a4d9.akpm@linux-foundation.org>
Date:	Mon, 10 Sep 2007 22:04:23 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Yoichi Yuasa <yoichi_yuasa@...peaks.co.jp>
Cc:	rpurdie@...ys.net,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] leds: add #include <linux/spinlock_types.h> to
 include/linux/leds.h for rwlock_t

On Tue, 4 Sep 2007 16:23:45 +0900 Yoichi Yuasa <yoichi_yuasa@...peaks.co.jp> wrote:

> 
> This patch has added #include <linux/spinlock_types.h> to include/linux/leds.h for rwlock_t.
> 
> Signed-off-by: Yoichi Yuasa <yoichi_yuasa@...peaks.co.jp>
> 
> diff -pruN -X generic/Documentation/dontdiff generic-orig/include/linux/leds.h generic/include/linux/leds.h
> --- generic-orig/include/linux/leds.h	2007-09-04 14:59:51.334686250 +0900
> +++ generic/include/linux/leds.h	2007-09-04 14:56:10.676896000 +0900
> @@ -13,6 +13,7 @@
>  #define __LINUX_LEDS_H_INCLUDED
>  
>  #include <linux/list.h>
> +#include <linux/spinlock_types.h>
>  
>  struct device;
>  /*

I think spinlock_types.h is more an internal implementation detail, and
that leds.h should be including plain old <linux/spinlock.h>.  Does that
change also fix whatever build error you were seeing?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/