linux-kernel - Re: [PATCH 2/2] Maple bus support for the SEGA Dreamcast

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d120d5000709102225n516d9c17m2120b64cef801625@mail.gmail.com>
Date:	Tue, 11 Sep 2007 01:25:58 -0400
From:	"Dmitry Torokhov" <dmitry.torokhov@...il.com>
To:	"Adrian McMenamin" <lkmladrian@...il.com>
Cc:	"Paul Mundt" <lethal@...ux-sh.org>, linux-kernel@...r.kernel.org,
	linuxsh-dev@...ts.sourceforge.net
Subject: Re: [PATCH 2/2] Maple bus support for the SEGA Dreamcast - Dreamcast keyboard support

On 9/10/07, Adrian McMenamin <lkmladrian@...il.com> wrote:
> +
> +	for (i = 0; i < NR_SCANCODES; i++)
> +		memcpy(kbd->keycode + i * sizeof(unsigned char), dc_kbd_keycode + i
> * sizeof(unsigned char),
> +				 sizeof(unsigned char));

Ahem... That's not what I had in mind when I asked for memcpy. How about:

        memcpy(kbd->keycode, dc_kbd_keycode, sizeof(kbd->keycode);

?

Thanks.

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/