linux-kernel - Re: [PATCH] pci: fix unterminated pci_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b6fcc0a0709120448s69528fc9reed593229124a4fa@mail.gmail.com>
Date:	Wed, 12 Sep 2007 15:48:49 +0400
From:	"Alexey Dobriyan" <adobriyan@...il.com>
To:	"Jeff Garzik" <jeff@...zik.org>
Cc:	"Kees Cook" <kees@...ntu.com>, linux-kernel@...r.kernel.org,
	"Ben Collins" <bcollins@...ntu.com>,
	"Michael Wu" <flamingice@...rmilk.net>,
	"Andrew Morton" <akpm@...ux-foundation.org>
Subject: Re: [PATCH] pci: fix unterminated pci_device_id lists

On 9/12/07, Jeff Garzik <jeff@...zik.org> wrote:
> Kees Cook wrote:
> > This patch against 2.6.23-rc6 fixes a couple drivers that do not
> > correctly terminate their pci_device_id lists.  This results in garbage
> > being spewed into modules.pcimap when the module happens to not have
> > 28 NULL bytes following the table, and/or the last PCI ID is actually
> > truncated from the table when calculating the modules.alias PCI aliases,
> > cause those unfortunate device IDs to not auto-load.
> >
> > Signed-off-by: Kees Cook <kees@...ntu.com>
>
> ACK

I mut say, non-terminated PCI ids lists are constant PITA. There should be
a way to a) put it in macro[1], so that terminator automatically added, and
b) still allow #ifdef inside table like, e.g. 8139too does.

[1] or not macro, because #ifdef inside macros aren't allowed.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/