linux-kernel - Re: [PATCH] ehca_irq: Misc cpuinit section annotations and #ifdef cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200709121752.27310.fenkes@de.ibm.com>
Date:	Wed, 12 Sep 2007 17:52:26 +0200
From:	Joachim Fenkes <fenkes@...ibm.com>
To:	Satyam Sharma <satyam@...radead.org>,
	Roland Dreier <rolandd@...co.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Hoang-Nam Nguyen <hnguyen@...ibm.com>,
	Christoph Raisch <raisch@...ibm.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ehca_irq: Misc cpuinit section annotations and #ifdef cleanups

On Thursday 23 August 2007 01:28, Satyam Sharma wrote:
> 
> * Replace {un}register_cpu_notifier with {un}register_hotcpu_notifier
>   thereby losing a couple of #ifdef HOTPLUG_CPU pairs.
> * Move comp_pool_callback_nb declaration to below that of callback
>   function so that initialization of .notifier_call and .priority can
>   occur at build time itself and not runtime.
> * Mark the notifier_block (and callback function, and another static
>   function used by it) as __cpuinit{data} for the sake of consistency
>   and remove enclosing #ifdef. (This may increase size for modular
>   build of this module, however, because these are no longer dropped
>   unconditionally now.)
> 
> Signed-off-by: Satyam Sharma <satyam@...radead.org>

Looks okay to me.

Acked-by: Joachim Fenkes <fenkes@...ibm.com>

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/