linux-kernel - [PATCH -mm v2] 2.6.23-rc4-mm1: kgdboe link errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070912112252.7658b7db.randy.dunlap@oracle.com>
Date:	Wed, 12 Sep 2007 11:22:52 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Matt Mackall <mpm@...enic.com>
Cc:	Jiri Slaby <jirislaby@...il.com>,
	kgdb-bugreport@...ts.sourceforge.net, amitkale@...syssoft.com,
	Linux kernel mailing list <linux-kernel@...r.kernel.org>,
	jason.wessel@...driver.com,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: [PATCH -mm v2] 2.6.23-rc4-mm1: kgdboe link errors

On Wed, 12 Sep 2007 13:15:12 -0500 Matt Mackall wrote:

> NETCONSOLE shouldn't be necessary. Otherwise this looks ok to my
> kconfig-addled brain.

Correct.  Patch corrected.  Thanks.

---
From: Randy Dunlap <randy.dunlap@...cle.com>

Fix kgdb build problems:
  Building modules, stage 2.
ERROR: "netpoll_cleanup" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_setup" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_parse_options" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_poll" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_send_udp" [drivers/net/kgdboe.ko] undefined!
ERROR: "netpoll_set_trap" [drivers/net/kgdboe.ko] undefined!
make[1]: *** [__modpost] Error 1

Add 'select' for net-poll related config symbols, but
make KGDBOE 'depend on' NET.  We don't want to 'select' CONFIG_NET,
but if it is already enabled, the 'select's will enable the rest
of the needed interfaces.

Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
---
 lib/Kconfig.kgdb |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-2.6.23-rc4-mm1.orig/lib/Kconfig.kgdb
+++ linux-2.6.23-rc4-mm1/lib/Kconfig.kgdb
@@ -174,9 +174,10 @@ endchoice

 config KGDBOE
 	tristate "KGDB: On ethernet" if !KGDBOE_NOMODULE
-	depends on m && KGDB
+	depends on m && KGDB && NET
 	select NETPOLL
 	select NETPOLL_TRAP
+	select NET_POLL_CONTROLLER
 	help
 	  Uses the NETPOLL API to communicate with the host GDB via UDP.
 	  In order for this to work, the ethernet interface specified must
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/