linux-kernel - Re: hci_sock.c build failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <200709131211.10950.toralf.foerster@gmx.de>
Date:	Thu, 13 Sep 2007 12:11:09 +0200
From:	Toralf Förster <toralf.foerster@....de>
To:	davem@...emloft.net
Cc:	linux-kernel@...r.kernel.org
Subject: Re: hci_sock.c build failure

Hello,

I'm wondering why the build failure wasn't fixed by a patch like this:


diff --git a/net/bluetooth/hci_sock.c b/net/bluetooth/hci_sock.c
index 5ccea5f..85416bb 100644
--- a/net/bluetooth/hci_sock.c
+++ b/net/bluetooth/hci_sock.c
@@ -348,8 +348,6 @@ static inline void hci_sock_cmsg(struct sock *sk, struct msghdr *msg, struct sk_

                skb_get_timestamp(skb, &tv);

-               data = &tv;
-               len = sizeof(tv);
 #ifdef CONFIG_COMPAT
                if (msg->msg_flags & MSG_CMSG_COMPAT) {
                        struct compat_timeval ctv;
@@ -358,6 +356,9 @@ static inline void hci_sock_cmsg(struct sock *sk, struct msghdr *msg, struct sk_
                        data = &ctv;
                        len = sizeof(ctv);
                }
+#else
+               data = &tv;
+               len = sizeof(tv);
 #endif

                put_cmsg(msg, SOL_HCI, HCI_CMSG_TSTAMP, len, data);


-- 
MfG/Sincerely

Toralf Förster
pgp finger print: 7B1A 07F4 EC82 0F90 D4C2 8936 872A E508 7DB6 9DA3

Download attachment "signature.asc " of type "application/pgp-signature" (190 bytes)