linux-kernel - Re: [PATCH 5/6] Filter based on a nodemask as well as a gfp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070913102531.GF22778@skynet.ie>
Date:	Thu, 13 Sep 2007 11:25:31 +0100
From:	mel@...net.ie (Mel Gorman)
To:	Christoph Lameter <clameter@....com>
Cc:	Lee.Schermerhorn@...com, kamezawa.hiroyu@...fujitsu.com,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH 5/6] Filter based on a nodemask as well as a gfp_mask

On (12/09/07 14:23), Christoph Lameter didst pronounce:
> On Wed, 12 Sep 2007, Mel Gorman wrote:
> 
> > -			z++)
> > -		;
> > +	if (likely(nodes == NULL))
> > +		for (; zonelist_zone_idx(z) > highest_zoneidx;
> > +				z++)
> > +			;
> > +	else
> > +		for (; zonelist_zone_idx(z) > highest_zoneidx ||
> > +				(z->zone && !zref_in_nodemask(z, nodes));
> > +				z++)
> > +			;
> >  
> 
> Minor nitpick here: "for (;" should become "for ( ;" to have correct 
> whitespace. However, it would be clearer to use a while here.
> 
> while (zonelist_zone_idx(z)) > highest_zoneidx)
> 		z++;
> 
> etc.

Good point. I'll clean it up and retest. Thanks

-- 
Mel Gorman
Part-time Phd Student                          Linux Technology Center
University of Limerick                         IBM Dublin Software Lab
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/